netdev - Re: [patch 2/2] qlcnic: using too much stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9F31A875-3A0B-4518-8106-1012E0D2799B@qlogic.com>
Date:	Mon, 9 Aug 2010 18:43:00 -0700
From:	Anirban Chakraborty <anirban.chakraborty@...gic.com>
To:	Dan Carpenter <error27@...il.com>
CC:	Amit Salecha <amit.salecha@...gic.com>,
	Linux Driver <Linux-Driver@...gic.com>,
	"David S. Miller" <davem@...emloft.net>,
	Sucheta Chakraborty <sucheta.chakraborty@...gic.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [patch 2/2] qlcnic: using too much stack


On Aug 10, 2010, at 12:12 AM, Dan Carpenter wrote:

> On Mon, Aug 09, 2010 at 09:46:32AM -0700, Anirban Chakraborty wrote:
>> 
>> It looks fine except that I'd use kzalloc instead of kcalloc above.
>> 
> 
> It's no problem to do that, and I'm already respinning the patches but 
> I'm confused.  It looks like pci_info gets initialized correctly.  What
> am I missing?

Your patch is fine except that the preferred way is to use kzalloc over kaclloc. kzalloc does not need that extra
argument that you are passing to kcalloc.

-Anirban--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html