netdev - Re: [patch 2/2] qlcnic: using too much stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D084A42E-7F2A-44F7-9273-DDD9214CB877@qlogic.com>
Date:	Mon, 9 Aug 2010 20:31:13 -0700
From:	Anirban Chakraborty <anirban.chakraborty@...gic.com>
To:	Joe Perches <joe@...ches.com>
CC:	Dan Carpenter <error27@...il.com>,
	Amit Salecha <amit.salecha@...gic.com>,
	Linux Driver <Linux-Driver@...gic.com>,
	"David S. Miller" <davem@...emloft.net>,
	Sucheta Chakraborty <sucheta.chakraborty@...gic.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [patch 2/2] qlcnic: using too much stack


On Aug 10, 2010, at 7:33 AM, Joe Perches wrote:

> On Mon, 2010-08-09 at 18:43 -0700, Anirban Chakraborty wrote:
>> Your patch is fine except that the preferred way is to use kzalloc over kaclloc. kzalloc does not need that extra
>> argument that you are passing to kcalloc.
> 
> You probably meant to write "my preferred way"
> as the kcalloc to "kzalloc with a multiply"
> ratio is pretty high.
> 
> It's actually about 2.5 to 1 in favor of kcalloc.
> 
> $ grep -rw --include=*.[ch] kcalloc * | wc -l
> 419
> 
> $ grep -rP --include=*.[ch] "\bkzalloc\s*\(\s*\w+\s*\*\s*\w+" * | \
>  grep -vP "\bkzalloc\s*\(\s*sizeof\s+\*\s*\w+\s*," | wc -l
> 164
> 
> (the grep -vP avoids kzalloc(sizeof *p, GFP_foo)
> 
> Actually, there might be a reason to use kzalloc
> in that location to match the other similar use
> a few lines away, but I'd prefer that the other
> use be converted to kcalloc.

I was suggesting based on the following:
http://lwn.net/Articles/147014/

thanks,
Anirban


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html