netdev - Re: [PATCH] pcnet_cs: Use proper netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100809153410.GA27238@comet.dominikbrodowski.net>
Date:	Mon, 9 Aug 2010 17:34:10 +0200
From:	Dominik Brodowski <linux@...inikbrodowski.net>
To:	Wolfram Sang <w.sang@...gutronix.de>, Joe Perches <joe@...ches.com>
Cc:	netdev@...r.kernel.org, linux-pcmcia@...ts.infradead.org,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] pcnet_cs: Use proper netdev_*-printouts

On Sun, Aug 08, 2010 at 02:32:05PM +0200, Wolfram Sang wrote:
> To prevent broken messages like:
> 
> [  204.024291] eth%d: pcnet_reset_8390() did not complete.
> 
> Signed-off-by: Wolfram Sang <w.sang@...gutronix.de>
> Cc: Dominik Brodowski <linux@...inikbrodowski.net>
> Cc: Joe Perches <joe@...ches.com>
> Cc: David Miller <davem@...emloft.net>

and

On Sun, Aug 08, 2010 at 07:50:36AM -0700, Joe Perches wrote:
> It looks as if the printks in get_ax88190 are
> incorrect and were duplicated and superceded by a
> test in pcnet_config, so I removed them.
> 
> Changed the level of the ax88190 test to KERN_NOTICE
> to match the other message styles in pcnet_config.
> 
> Compiled but untested.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

look good from a PCMCIA point of view, therefore:

Signed-off-by: Dominik Brodowski <linux@...inikbrodowski.net>

Thanks,
	Dominik
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html