netdev - Re: [iproute2] iproute2: Fix 'addr flush secondary' logic.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C630B0A.9010304@hp.com>
Date:	Wed, 11 Aug 2010 16:41:46 -0400
From:	Brian Haley <brian.haley@...com>
To:	Ben Greear <greearb@...delatech.com>
CC:	netdev@...r.kernel.org
Subject: Re: [iproute2] iproute2:  Fix 'addr flush secondary' logic.

On 08/11/2010 01:19 PM, Ben Greear wrote:
> @@ -648,7 +648,7 @@ int print_addrinfo_secondary(const struct sockaddr_nl *who, struct nlmsghdr *n,
>  {
>  	struct ifaddrmsg *ifa = NLMSG_DATA(n);
>  
> -	if (ifa->ifa_flags & IFA_F_SECONDARY)
> +	if (!ifa->ifa_flags & IFA_F_SECONDARY)
>  		return 0;

Shouldn't this be:

	if (!(ifa->ifa_flags & IFA_F_SECONDARY))

-Brian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html