netdev - Re: [patch net-next-2.6] bridge: allow hub-like behaviour

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100812132002.GE3115@psychotron.brq.redhat.com>
Date:	Thu, 12 Aug 2010 15:20:03 +0200
From:	Jiri Pirko <jpirko@...hat.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	netdev@...r.kernel.org, shemminger@...ux-foundation.org,
	bridge@...ts.linux-foundation.org, davem@...emloft.net
Subject: Re: [patch net-next-2.6] bridge: allow hub-like behaviour

Thu, Aug 12, 2010 at 02:55:20PM CEST, shemminger@...tta.com wrote:
>On Thu, 12 Aug 2010 14:48:48 +0200
>Jiri Pirko <jpirko@...hat.com> wrote:
>
>> Thu, Aug 12, 2010 at 02:35:41PM CEST, shemminger@...tta.com wrote:
>> >On Thu, 12 Aug 2010 13:15:24 +0200
>> >Jiri Pirko <jpirko@...hat.com> wrote:
>> >
>> >> Wed, Aug 11, 2010 at 06:07:41PM CEST, shemminger@...tta.com wrote:
>> >> >NO. unnecessary
>> >> >
>> >> >Already possible, without patch. Just set the hold time
>> >> >on the bridge to 0!
>> >> 
>> >> Sorry, but could you please point me a sysfs node where should I do this
>> >> setting? Unable to find this.
>> >> 
>> >> Thanks.
>> >> 
>> >
>> >/sys/class/net/ethX/brport/hold_timer
>> 
>> That's read-only:
>> 
>> static BRPORT_ATTR(hold_timer, S_IRUGO, show_hold_timer, NULL);
>> 
>
>Guess you have to use ioctl() interface to change it for now.
>Looks like a missed opportunity when sysfs support was added.
>There are some other values like forward_delay that have same problem.


Oh you mislead me. It's not hold_timer but hold_time function:

static inline unsigned long hold_time(const struct net_bridge *br)
{
        return br->topology_change ? br->forward_delay : br->ageing_time;
}

called from br_fdb_update().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html