netdev - Re: [PATCH] Add firmware label support to iproute2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100812141240.417949e2@s6510>
Date:	Thu, 12 Aug 2010 14:12:40 -0400
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Narendra K <Narendra_K@...l.com>
Cc:	netdev@...r.kernel.org, matt_domsch@...l.com,
	charles_rose@...l.com, jordan_hargrave@...l.com
Subject: Re: [PATCH] Add firmware label support to iproute2

On Thu, 12 Aug 2010 12:35:37 -0500
Narendra K <Narendra_K@...l.com> wrote:

> +#ifndef LIBNETDEVNAME_PRESENT
>  			filter_dev = *argv;
> +#else
> +			if (netdev_alias_to_kernelname(*argv, kernel_name) < 0)
> +				show_firmware_alias_usage(*argv);
> +			filter_dev = kernel_name;
> +#endif
>  		}

like the kernel, I don't like ifdef cases in main code.
You should put in stub inline that returns appropriate error.

What happens if alias matches existing interface name?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html