netdev - Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinEtrpE8UAW2+ybRP7YmQ0aPBp5fq2q7P+-HMgV@mail.gmail.com>
Date:	Fri, 13 Aug 2010 09:11:50 +0300
From:	Daniel Baluta <daniel.baluta@...il.com>
To:	"Wang, Qi" <qi.wang@...el.com>
Cc:	Wolfgang Grandegger <wg@...ndegger.com>,
	Masayuki Ohtak <masa-korg@....okisemi.com>,
	"meego-dev@...go.com" <meego-dev@...go.com>,
	"socketcan-core@...ts.berlios.de" <socketcan-core@...ts.berlios.de>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Khor, Andrew Chih Howe" <andrew.chih.howe.khor@...el.com>,
	"gregkh@...e.de" <gregkh@...e.de>,
	"arjan@...ux.intel.com" <arjan@...ux.intel.com>,
	"Wang, Yong Y" <yong.y.wang@...el.com>
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_CAN driver to 2.6.35

Hi,
> I'm not familiar with kfifo structure, and I didn't like it because there need a spin_lock to use it.

It seems that you don't need to use your own kfifo. Socket-CAN core has
it's internal queues, you only have to fit in this infrastructure.

>>
>> > Daniel,
>> >
>> > We're anxious to integrate those codes now. Perhaps it'll take us quite a long
>> time to use kfifo. How about implementing it with the next version?
>>
>> See above. What do you mean with the next version. The driver posted by
>> Masayuki is far away from being accepted as it does not yet comply with
>> the Socket-CAN driver API, to say the least.
> I've few experience on CAN driver and it's also the first time for OKI-san to write Can driver. Would you please give us a reference and we'll follow it up. We only read 'can.txt' from kernel document. Thank you for your help in advance.

Oliver's email should be your starting point. Read the code from net/can and see
how other drivers are built.

As I previously said I'm interested in writing a driver for CAN
EP80579 controller,
but the start is pretty slow. Since your controller seems to be pretty
similar we
can do some things in common.

I can help you, if you send me a pointer to your CAN controller
datasheet + eventually
grant me access to your repo.

thanks,
Daniel.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html