netdev - Re: [PATCH v2 0/3] cxgbi iscsi driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C657386.6050308@cs.wisc.edu>
Date:	Fri, 13 Aug 2010 11:32:06 -0500
From:	Mike Christie <michaelc@...wisc.edu>
To:	kxie@...lsio.com
CC:	netdev@...r.kernel.org, linux-scsi@...r.kernel.org,
	open-iscsi@...glegroups.com, rranjan@...lsio.com,
	James.Bottomley@...senPartnership.com, davem@...emloft.net
Subject: Re: [PATCH v2 0/3] cxgbi iscsi driver

On 08/13/2010 10:19 AM, kxie@...lsio.com wrote:
> [PATCH v2 0/3] cxgbi iscsi driver
>
> From: Karen Xie<kxie@...lsio.com>
>
> Re-submission, missed netdev list last time.
>
> This patchset includes:
>
> 1. added libcxgbi as the common library for both cxgb4i and cxgb3i driver
> 2. added cxgb4i iscsi initiator v5.
> 3. changed cxgb3i to use libcxgbi.
>
> The version 2 includes the following changes:
> - Made dbg_level static to avoid compiling errors when both cxgb3i and cxgb4i
>    are built into the kernel.
> - Deleted cxgbi_fill_iscsi_transport() and cxgbi_fill_scsi_host_template().
>    The iscsi_transport and scsi_host_template are initialized in the drivers
>    instead of being filled in by the library at runtime..
> - Only register with iscsi class transport once per driver type.
>

iSCSI and SCSI parts look ok now. The network code should be reviewed by 
the netdev people, because I am not qualified to review that. Thanks for 
your work Karen.

Reviewed-by: Mike Christie <michaelc@...wisc.edu>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html