[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1282056532.24541.89.camel@Joe-Laptop>
Date: Tue, 17 Aug 2010 07:48:52 -0700
From: Joe Perches <joe@...ches.com>
To: Amit Kumar Salecha <amit.salecha@...gic.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org,
ameen.rahman@...gic.com,
Sucheta Chakraborty <sucheta.chakraborty@...gic.com>
Subject: Re: [PATCHv3 NEXT 7/7] qlcnic: turn off lro when rxcsum is
disabled.
On Tue, 2010-08-17 at 03:34 -0700, Amit Kumar Salecha wrote:
> From: Sucheta Chakraborty <sucheta.chakraborty@...gic.com>
Thanks all, 2 minor comments below.
> --- a/drivers/net/qlcnic/qlcnic_ethtool.c
> +++ b/drivers/net/qlcnic/qlcnic_ethtool.c
> @@ -818,7 +818,21 @@ static u32 qlcnic_get_rx_csum(struct net_device *dev)
> static int qlcnic_set_rx_csum(struct net_device *dev, u32 data)
[]
> dev_info(&adapter->pdev->dev, "disabling LRO as rx_csum is off\n");
I think netdev_<level> should be used when a
struct net_device * is available.
netdev_info(dev, "disabling LRO as rx_csum is off\n");
> @@ -1001,6 +1015,15 @@ static int qlcnic_set_flags(struct net_device *netdev, u32 data)
[]
> + if (!adapter->rx_csum) {
> + dev_info(&adapter->pdev->dev, "rx csum is off, "
> + "cannot toggle lro\n");
netdev_info(netdev, "rx csum is off, cannot toggle LRO\n");
and please use consistent acronym case.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists