netdev - Re: [PATCH] ether3: Use net_device_stats from struct net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100817185356.GG15670@distanz.ch>
Date:	Tue, 17 Aug 2010 20:53:56 +0200
From:	Tobias Klauser <tklauser@...tanz.ch>
To:	Dan Carpenter <error27@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Russell King <linux@....linux.org.uk>, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ether3: Use net_device_stats from struct net_device

On 2010-08-17 at 20:35:52 +0200, Dan Carpenter <error27@...il.com> wrote:
> On Tue, Aug 17, 2010 at 06:15:33PM +0200, Tobias Klauser wrote:
> > struct net_device has its own struct net_device_stats member, so use
> > this one instead of a private copy in the ether1_priv struct.
> > 
> 
> Two were missed, one from ether3_init_for_open()
> 
> 	memset(&priv(dev)->stats, 0, sizeof(struct net_device_stats));
> 
> and another from ether3_rx().
> 
> 	struct net_device_stats *stats = &priv(dev)->stats;

Thanks a lot again. I'll send an updated patch. Please disregard this
one.

(I wasn't able to cross-compile-test the patch here, otherwise these
would hopefully have been caught by the compiler).

  Tobias
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html