lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 Aug 2010 10:33:35 +0200 From: Tobias Klauser <tklauser@...tanz.ch> To: Eric Dumazet <eric.dumazet@...il.com> Cc: Russell King - ARM Linux <linux@....linux.org.uk>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, kernel-janitors@...r.kernel.org, Dan Carpenter <error27@...il.com> Subject: Re: [PATCH v2] ether1: Use net_device_stats from struct net_device On 2010-08-18 at 10:27:53 +0200, Eric Dumazet <eric.dumazet@...il.com> wrote: > Le mercredi 18 août 2010 à 09:13 +0100, Russell King - ARM Linux a > écrit : > > On Wed, Aug 18, 2010 at 09:04:24AM +0200, Tobias Klauser wrote: > > > @@ -965,7 +965,7 @@ ether1_close (struct net_device *dev) > > > static struct net_device_stats * > > > ether1_getstats (struct net_device *dev) > > > { > > > - return &priv(dev)->stats; > > > + return &dev->stats; > > > } > > > > Doesn't the core do this for you already if you omit this function? > > > > Same comment for ether3.c > > Yes, thats right, no need to declare ndo_get_stats() methods that only > returns &dev->stats Thanks. I'll send another updated patch, omitting the ether1_getstats (same for ether3). Sorry for the mess. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists