netdev - Re: [PATCH v3] PPTP: PPP over IPv4 (Point-to-Point Tunneling Protocol)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Aug 2010 14:38:58 +0400
From:	Dmitry Kozlov <xeb@...l.ru>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v3] PPTP: PPP over IPv4 (Point-to-Point Tunneling Protocol)

Hi Eric!
Thanks for comments. All your comments was accepted except:

> > +static struct ppp_channel_ops pptp_chan_ops = {
> 
> static const ?

not, because po->chan.ops = &pptp_chan_ops which is not const

> > +static DEFINE_RWLOCK(gre_proto_lock);
> 
> This could use RCU and a spinlock instead
> 

rcu + mutex

Patch v4 will be ready soon...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html