netdev - Re: [PATCH net-next 11/14] tipc: Eliminate useless linked list initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Aug 2010 09:28:27 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, allan.stephens@...driver.com
Subject: Re: [PATCH net-next 11/14] tipc: Eliminate useless linked list initialization

On 10-08-17 08:29 PM, David Miller wrote:
> From: Paul Gortmaker<paul.gortmaker@...driver.com>
> Date: Tue, 17 Aug 2010 17:00:13 -0400
> 
>> From: Allan Stephens<allan.stephens@...driver.com>
>>
>> Eliminate the initialization of the port_list field of a newly created
>> TIPC port, since the port is immediately added to TIPC's global list
>> of ports (which alters the port_list field).
>>
>> Signed-off-by: Allan Stephens<allan.stephens@...driver.com>
>> Signed-off-by: Paul Gortmaker<paul.gortmaker@...driver.com>
> 
> This is not correct.
> 
> INIT_LIST_HEAD() is mandatory for all new objects, since it may
> initialize debugging knobs and whatnot inside of the list_head object
> when certain debugging options are enabled.
> 
> Therefore it may never be elided.

Thanks, I should have come to the same conclusion when I was looking
at that one.

P.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html