netdev - Re: [PATCH net-next-2.6] vxge: Implement 64bit stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1282145323.2194.105.camel@edumazet-laptop>
Date:	Wed, 18 Aug 2010 17:28:43 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jon Mason <jon.mason@...r.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Ramkrishna Vepa <Ramkrishna.Vepa@...r.com>,
	Sivakumar Subramani <Sivakumar.Subramani@...r.com>,
	Sreenivasa Honnur <Sreenivasa.Honnur@...r.com>
Subject: Re: [PATCH net-next-2.6] vxge: Implement 64bit stats

Le mercredi 18 août 2010 à 10:25 -0500, Jon Mason a écrit :
> On Wed, Aug 18, 2010 at 06:42:54AM -0700, Eric Dumazet wrote:
> > vxge_get_stats() is racy, since it clears a block of memory (net_stats)
> > possibly still used by other cpus.
> > 
> > We can update this driver to full 64bit stats, since ndo_get_stats64()
> > provides a private block to store results, and driver maintains 64bit
> > counters already.
> > 
> > We also remove net_stats field from struct vxge_sw_stats
> 
> It looks sane.  Assuming you have not tested it already, I'll give it a
> quick sanity check.

I did not test it, I would be grateful if you can do this ;)

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html