netdev - Re: [PATCH v5 0/3] cxgbi iscsi driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C6DB384.6020009@cs.wisc.edu>
Date:	Thu, 19 Aug 2010 17:43:16 -0500
From:	Mike Christie <michaelc@...wisc.edu>
To:	kxie@...lsio.com
CC:	netdev@...r.kernel.org, linux-scsi@...r.kernel.org,
	open-iscsi@...glegroups.com, rranjan@...lsio.com, joe@...ches.com,
	James.Bottomley@...senPartnership.com, davem@...emloft.net
Subject: Re: [PATCH v5 0/3] cxgbi iscsi driver

On 08/16/2010 10:55 PM, kxie@...lsio.com wrote:
> [PATCH v5 0/3] cxgbi iscsi driver
>
> From: Karen Xie<kxie@...lsio.com>
>
> This patchset includes:
>
> 1. added libcxgbi as the common library for both cxgb4i and cxgb3i driver
> 2. added cxgb4i iscsi initiator v5.
> 3. changed cxgb3i to use libcxgbi.
>
> Version 5 changes:
> - got rid of log_error/warn/info and used pr_<level>  instead.
> - "%zu" for printing out sizeof().
> - made sure all printk messages have trailing "."
>

iSCSI and scsi parts look ok to me.

Reviewed-by: Mike Christie <michaelc@...wisc.edu>

I looked at the network code and it looks similar to what is in the 
cxgb3i driver upstream, so I think it should be ok, but I am not 100% 
sure so probably needs a netdev ack.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html