netdev - Re: [PATCH v2] netfilter: save the hash of the tuple in the original direction for latter use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinA3-KMPKJa-66QCMUpbDFwey2mjE=VN=9=zg=6@mail.gmail.com>
Date:	Fri, 20 Aug 2010 07:10:40 +0800
From:	Changli Gao <xiaosuo@...il.com>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Patrick McHardy <kaber@...sh.net>,
	"David S. Miller" <davem@...emloft.net>,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2] netfilter: save the hash of the tuple in the original
 direction for latter use

On Fri, Aug 20, 2010 at 12:11 AM, Mathieu Desnoyers
<mathieu.desnoyers@...ymtl.ca> wrote:
>
> Ah, I see. But I think the static variable should stay declared outside
> of the function scope, with a nice comment explaining why it's not
> initialized at init-time.
>
> Hiding global state in function code is usually frowned upon.
>

I don't agree with you. We'd better not expose the variable which
isn't expected to be used by others. If not, maybe someone will misuse
it. The user should only reply on the interface, but not the internal
implementation.

Thanks.

-- 
Regards,
Changli Gao(xiaosuo@...il.com)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html