netdev - Re: [PATCH 1/1] ehea: Allocate stats buffer with GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100819.005323.73677219.davem@davemloft.net>
Date:	Thu, 19 Aug 2010 00:53:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fubar@...ibm.com
Cc:	eric.dumazet@...il.com, brking@...ux.vnet.ibm.com,
	ossthema@...ibm.com, osstklei@...ibm.com, raisch@...ibm.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] ehea: Allocate stats buffer with GFP_KERNEL

From: Jay Vosburgh <fubar@...ibm.com>
Date: Wed, 18 Aug 2010 10:49:41 -0700

> 	So, the real question is whether the ndo_get_stats* functions
> are permitted to sleep.  If they are, then bonding and netstat_show both
> need to change.  If not, then ehea needs to change.  Ehea is probably
> not alone in this; I poked around a bit, and it looks like mlx4 may also
> sleep in ndo_get_stats.

They really can't currently.... so EHEA will need to be changed
such that it can do stats fetching atomically.

In the long term, we could allow this.

The netstat_stat function should be RCU'able.  And something
similar, I suppose, should be possible on the bonding side.

But as it stands EHEA has to be fixed and can't stay as-is.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html