netdev - Re: [patch v2] qlge: pull NULL check ahead of dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100819.204818.13765444.davem@davemloft.net>
Date:	Thu, 19 Aug 2010 20:48:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ron.mercer@...gic.com
Cc:	error27@...il.com, Linux-Driver@...gic.com,
	leitao@...ux.vnet.ibm.com, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch v2] qlge: pull NULL check ahead of dereference

From: Ron Mercer <ron.mercer@...gic.com>
Date: Thu, 19 Aug 2010 13:28:36 -0700

> On Thu, Aug 19, 2010 at 11:52:44AM -0700, Dan Carpenter wrote:
>> There was a dereference before NULL check issue introduced in 1e213303d
>> "qlge: Add tx multiqueue support."  I've pulled the NULL check of
>> "net_rsp" forward a couple lines to avoid that.
>> 
>> Also Ron Mercer says that the early exit should be above the index
>> write.  ql_write_cq_idx(rx_ring);
>> 
> 
> Signed-off-by: Ron Mercer <ron.mercer@...gic.com>

Applied to net-next-2.6, thanks guys.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html