netdev - Re: TAHI CN-6-4-1 failed on Linux 2.6.32 kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100819.170649.212693227.davem@davemloft.net>
Date:	Thu, 19 Aug 2010 17:06:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	schen@...sta.com
Cc:	brian.haley@...com, usagi-users-ctl@...linux-ipv6.org,
	netdev@...r.kernel.org
Subject: Re: TAHI CN-6-4-1 failed on Linux 2.6.32 kernel

From: Steve Chen <schen@...sta.com>
Date: Thu, 19 Aug 2010 13:35:14 -0500

> I trace through the code.  It appears that the network driver (e1000e
> for my setup) always set ip_summed to CHECKSUM_UNNECESSARY.  I have
> been unsuccessful to get the driver to take the other branch where
> ip_summed is set to CHECKSUM_COMPLETE.  Even when I hard code
> ip_summed to CHECKSUM_COMPLETE, __skb_checksum_complete_head set
> ip_summed to CHECKSUM_UNNECESSARY after recomputing the checksum.
> 
> So far the only way I'm able to get ICMP to recompute checksum is
> through the attached hack.  Even though I can get all the tests to
> pass, but it just seem wrong.

If turning off hardware RX checksumming with ethtool has no effect,
and the problem is seen with multiple ethernet cards, the problem
is elsewhere.

First of all, if you turn RX checksumming off, the checksum field
of the SKB should always be skb->ip_summed = 0.  If this is not
happening, find out why.

Put diagnostics into drivers/net/e1000e/netdev.c:e1000_rx_checksum()
and see what's happening.

If that code isn't setting ->ip_summed, then something else is,
perhaps some decapsulation code?  Do these packets get embedded
in a tunnel or other kind of transport?  I see that this test
has IPSEC disabled, so it can't be that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html