netdev - Re: [PATCH v7] PPTP: PPP over IPv4 (Point-to-Point Tunneling Protocol)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1282285499.2295.2.camel@edumazet-laptop>
Date:	Fri, 20 Aug 2010 08:24:59 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Dmitry Kozlov <xeb@...l.ru>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v7] PPTP: PPP over IPv4 (Point-to-Point Tunneling
 Protocol)

Le jeudi 19 août 2010 à 13:28 +0400, Dmitry Kozlov a écrit :
> Ang again...
> This patch contains:
> 1. pptp driver
> 2. gre demultiplexer driver for demultiplexing gre packets with different gre version
> so ip_gre and pptp may coexists
> 3. ip_gre modification
> 4. other stuff
> 
> Changes from v6:
> 1. memory allocation moved to begin of module initialization
> 2. fixed coding style issues
> Thanks to Eric Dumazet.
> 
> --
>  MAINTAINERS              |   14 +
>  drivers/net/Kconfig      |   11 +
>  drivers/net/Makefile     |    1 +
>  drivers/net/pptp.c       |  726 ++++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/if_pppox.h |   59 +++--
>  include/net/gre.h        |   18 ++
>  net/ipv4/Kconfig         |    7 +
>  net/ipv4/Makefile        |    1 +
>  net/ipv4/gre.c           |  151 ++++++++++
>  net/ipv4/ip_gre.c        |   14 +-
>  10 files changed, 975 insertions(+), 27 deletions(-)


Seems fine to me, but you need to make a nice looking Changelog and add
your "Signed-off-by: ...." signature.

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html