netdev - Re: [PATCH 2/8] net: rps: skip fragment when computing rxhash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100819.171116.233682060.davem@davemloft.net>
Date:	Thu, 19 Aug 2010 17:11:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	xiaosuo@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH 2/8] net: rps: skip fragment when computing rxhash

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 18 Aug 2010 08:25:01 +0200

> Le mercredi 18 août 2010 à 13:01 +0800, Changli Gao a écrit :
>> Fragmented IP packets may have no transfer header, so when computing
>> rxhash, we should skip them.
>> 
>> Signed-off-by: Changli Gao <xiaosuo@...il.com>
 ...
> Acked-by: Eric Dumazet <eric.dumazet@...il.com>

Applied.

> BTW, it is nicer to add some spaces :
> 
> 	if (ip->frag_off & htons(IP_MF | IP_OFFSET))

I took care of this.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html