netdev - Re: [PATCH 1/2] netfilter: fix the hash random initializing race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1282321600.2484.297.camel@edumazet-laptop>
Date:	Fri, 20 Aug 2010 18:26:40 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jan Engelhardt <jengelh@...ozas.de>
Cc:	Changli Gao <xiaosuo@...il.com>, Patrick McHardy <kaber@...sh.net>,
	"David S. Miller" <davem@...emloft.net>,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] netfilter: fix the hash random initializing race

Le vendredi 20 août 2010 à 18:20 +0200, Jan Engelhardt a écrit :
> On Friday 2010-08-20 18:17, Eric Dumazet wrote:
> >> +	if (unlikely(!nf_conntrack_hash_rnd)) {
> >> +		unsigned int rand;
> >> +
> >> +		/* Why not initialize nf_conntrack_rnd in a "init()" function ?
> >> +		 * Because there isn't enough entropy when system initializing,
> >> +		 * and we initialize it as late as possible. */
> >
> >This patch is fine but a fine multi line comment is :
> >	/* Some
> >	 * fine
> >	 * comment
> >	 */
> 
> Actually,
> 
> 	/*
> 	 * Some
> 	 */
> 
> But that's in CodingStyle already. Always a good read, even if reread.

Sorry, I documented David S. Miller choice, or else I would have
mentioned CodingStyle :)

	/* Some
	 * fine
	 * comment
	 */

And it really is better ;)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html