netdev - Re: [iproute2] iproute2: Fix filtering related to flushing IP addresses.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100823081528.46bc001e@nehalam>
Date:	Mon, 23 Aug 2010 08:15:28 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Ben Greear <greearb@...delatech.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [iproute2] iproute2:  Fix filtering related to flushing IP
 addresses.

On Mon, 16 Aug 2010 10:00:08 -0700
Ben Greear <greearb@...delatech.com> wrote:

> The old 'ip addr flush' logic had several flaws:
> 
> * It reversed logic for primary v/s secondary flags
>   (though, it sort of worked right anyway)
> 
> * The code tried to remove secondaries and then primaries,
>   but in practice, it always removed one primary per loop,
>   which not at all efficient.
> 
> * The filter logic in the core would run only the first
>   filter in most cases.
> 
> * If you used '-s -s', the ifa_flags member would be
>   modified, which could make future filters fail
>   to function fine.
> 
> This patch attempts to fix all of these issues.
> 
> Tested-by: Brian Haley <brian.haley@...com>
> Signed-off-by: Ben Greear <greearb@...delatech.com>

applied

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html