netdev - Re: [PATCH] tcp: make TCP quick ACK behavior modifiable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100823.152330.184822588.davem@davemloft.net>
Date:	Mon, 23 Aug 2010 15:23:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	chris.snook@...il.com
Cc:	hagen@...u.net, eric.dumazet@...il.com, netdev@...r.kernel.org,
	ilpo.jarvinen@...sinki.fi, acme@...hat.com, shemminger@...tta.com
Subject: Re: [PATCH] tcp: make TCP quick ACK behavior modifiable

From: Chris Snook <chris.snook@...il.com>
Date: Mon, 23 Aug 2010 18:19:45 -0400

> Just because we've allowed stupid TCP sysctls in the past does not
> mean we should continue to do so now.  We recently made delayed ack a
> per-route tunable, so consistency would suggest we do the same here.
> Per-route tunables are more flexible, and as with the delayed ack
> patch, there are use cases where that granularity gives a clear
> advantage over a sysctl.  For example, you may want to disable quick
> ack on a high-MTU path and enable it on a low-MTU path.
> 
> If you need a hint for how to implement the per-route tunable, look
> for the delayed ack patch from early 2009.

I completely agree with Chris that this should be a per-route rather
than a global sysctl tunable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html