netdev - Re: [PATCH] mlx4: use bitmap library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinNf1vsQqR34Qeh4jO-xt7m1wYWGC9-dA6mU+__@mail.gmail.com>
Date:	Mon, 23 Aug 2010 13:21:55 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, rolandd@...co.com
Subject: Re: [PATCH] mlx4: use bitmap library

2010/8/23 David Miller <davem@...emloft.net>:
> From: Akinobu Mita <akinobu.mita@...il.com>
> Date: Sat, 21 Aug 2010 18:24:48 +0900
>
>> Use bitmap_set() and bitmap_clear()
>>
>> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
>
> Unlike loops calling set_bit() and clear_bit(), bitmap_set() and
> bitmap_clear() are not atomic.
>
> Are you sure this is ok here?
>

I think this ok. Because the bitmap region is searched by
bitmap_find_next_zero_area() which cannot be atomic and
setting and clearing the bitmap region is protected by bitmap->lock
(except for initialization of the bitmap in mlx4_bitmap_init).

This change should be done when I submitted commit
43ff8b60853793fb0155b3e465739d2170c3aa2f ("mlx4: use
bitmap_find_next_zero_area")
at the same time.

I'll recheck this is ok and update the commit message for this change,
then resubmit the patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html