netdev - Re: [Patch 1/2] s2io: remove lro parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C72346C.9020606@redhat.com>
Date:	Mon, 23 Aug 2010 16:42:20 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Jon Mason <jon.mason@...r.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>,
	Ramkrishna Vepa <Ramkrishna.Vepa@...r.com>,
	"sgruszka@...hat.com" <sgruszka@...hat.com>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [Patch 1/2] s2io: remove lro parameter

On 08/20/10 16:54, Cong Wang wrote:
> On 08/18/10 23:36, Jon Mason wrote:
>> On Wed, Aug 18, 2010 at 12:51:09AM -0700, Amerigo Wang wrote:
>>>
>>> As suggested by David, this parameter can die, we can use ethtool
>>> to turn LRO on/off. Compile tests only.
>>
>> Needs some additional removal
>>
>> Line 41 and 42 " * lro: Specifies whether to enable Large Receive ..."
>> As you have removed the modparm
>>
>> Line 8286 "if (sp->lro)"
>> As it will always be on in this instance
>>
>>
>> Also, all references to "sp->lro" can be converted to "(dev->features
>> & NETIF_F_LRO)", removing an unnecessary variable.
>>
>
> Thanks for pointing these out.
> I will fix them later.
>

Done, please review the patch below.

Thanks!

-- 

Remove "lro" parameter of s2io driver.

Signed-off-by: WANG Cong <amwang@...hat.com>

View attachment "drivers-net-s2io-remove-lro-param.diff" of type "text/x-patch" (3913 bytes)