netdev - Re: [PATCH net-next-2.6] net: copy_rtnl_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Aug 2010 20:45:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] net: copy_rtnl_link_stats64()
 simplification

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Mon, 23 Aug 2010 18:21:36 +0100

> On Mon, 2010-08-23 at 19:14 +0200, Eric Dumazet wrote:
>> No need to use a temporary struct rtnl_link_stats64 variable,
>> just copy the source to skb buffer.
> 
> Yes, this makes sense.
> 
> The reason I didn't do this initially was that I was concerned about
> possible tearing of asynchronously-updated stats.  Since you made
> dev_get_stats() copy into a caller-provided buffer, this is no longer a
> concern.
> 
> For what it's worth:
> 
>> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Reviewed-by: Ben Hutchings <bhutchings@...arflare.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html