netdev - Re: tcp_shift_skb_data uses wrong mss in non-gso case?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100824074637.GA24604@gondor.apana.org.au>
Date:	Tue, 24 Aug 2010 00:46:37 -0700
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Jesse Brandeburg <jesse.brandeburg@...il.com>
Cc:	Robert Evans <robert.evans@...daqomx.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: tcp_shift_skb_data uses wrong mss in non-gso case?

On Mon, Aug 23, 2010 at 03:34:04PM -0700, Jesse Brandeburg wrote:
> CC Ilpo, the creator of this patch being discussed:
> 
> On Tue, Aug 17, 2010 at 3:35 PM, Robert Evans
> > This ends up being troublesome if the segment is later retransmitted and the
> > device driver has trouble with very small gso_size (e1000e seems to be an
> > example).

I don't see the problem.  If mss == skb->len then tcp_shifted_skb
will zero gso_size.

Which code path is setting gso_size to skb->len?

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html