netdev - RE: [net-next-2.6 1/1]: bna: Fix build break for allyesconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E5313AF6F2BFD14293E5FD0F94750F86A4AE226112@HQ1-EXCH01.corp.brocade.com>
Date:	Wed, 25 Aug 2010 16:05:43 -0700
From:	Rasesh Mody <rmody@...cade.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Akshay Mathur <amathur@...cade.com>,
	Debashis Dutt <ddutt@...cade.COM>,
	Jing Huang <huangj@...cade.COM>
Subject: RE: [net-next-2.6 1/1]: bna: Fix build break for allyesconfig

>From: David Miller <mailto:davem@...emloft.net>
>Sent: Wednesday, August 25, 2010 3:23 PM
>
>From: Rasesh Mody <rmody@...cade.com>
>Date: Wed, 25 Aug 2010 14:32:10 -0700
>
>> From: Rasesh Mody <rmody@...cade.com>
>> 
>> This patch contains a fix for the build break caused by multiple
>> definitions of symbols between Brocade's FC/FCOE driver(BFA) 
>> and 10G Networking Driver(BNA).
>> 
>> The fix is to make BNA a module only driver.
>> 
>> Signed-off-by: Debashis Dutt <ddutt@...cade.com>
>> Signed-off-by: Rasesh Mody <rmody@...cade.com>
>
>You have to be kidding me.  This fix is totally unacceptable.
>
>You have to go through your two drivers and:
>
>1) Mark as 'static' symbols that don't actually need global
>   visibility.
>
>2) Make the two drivers use unique namespaces for the function
>   names that must be globally visible for whatever reason.
>
>You are really trying my patience, fix this properly and promptly
>or I'm removing your driver from the tree.

David,

We are working on fixing it properly. We will submit the patches as soon as possible.

Thanks,
Rasesh
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html