netdev - Re: [PATCH] ll_temac: Fix poll implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 25 Aug 2010 14:24:05 +0200
From:	Michal Simek <monstr@...str.eu>
To:	David Miller <davem@...emloft.net>
CC:	glikely@...retlab.ca, netdev@...r.kernel.org, rusty@...tcorp.com.au
Subject: Re: [PATCH] ll_temac: Fix poll implementation

David Miller wrote:
> From: Michal Simek <monstr@...str.eu>
> Date: Wed, 18 Aug 2010 12:26:34 +0200
> 
>> Functions ll_temac_rx_irq and ll_temac_tx_irq
>> have pointer to net_device as second parameter not
>> pointer to temac_local.
>>
>> Signed-off-by: Michal Simek <monstr@...str.eu>
> 
> Applied, thanks a lot.
> 
> I can't count how many times this kind of error has been
> introduced.  It's of cource because the handle passed to
> IRQ handlers is an opaque void pointer, so if the underlying
> type gets changed there is absolutely no type checking done
> against by-hand calls of the IRQ handler.
> 
> Rusty Russell was, if I remember correctly, doing some work
> to correct this such that IRQ handlers could in fact have
> some proper typing in their handlers.  Or maybe that was for
> timer handlers?
> 
> Anyways that kind of thing would help here.
> 
> Rusty?

Rusty, you there?

Michal


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html