netdev - Re: [patch 08/20] ibmveth: Dont overallocate buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 25 Aug 2010 08:44:16 -0500
From:	Brian King <brking@...ux.vnet.ibm.com>
To:	Anton Blanchard <anton@...ba.org>, santil@...ux.vnet.ibm.com,
	netdev@...r.kernel.org
Subject: Re: [patch 08/20] ibmveth: Dont overallocate buffers

On 08/23/2010 03:49 PM, Robert Jennings wrote:
> * Anton Blanchard (anton@...ba.org) wrote:
>> We were allocating a page, even though we always want 4k. Use kmalloc
>> instead of get_zeroed_page.
> 
> I get a failure during device open when we have a 4k allocation rather
> than a 64k page allocation.  This is running on a Power6 LPAR without
> AMS.
> 
> (drivers/net/ibmveth.c:621 ua:3000000c) ERROR: h_register_logical_lan failed with -4
> (drivers/net/ibmveth.c:626 ua:3000000c) ERROR: buffer TCE:0x300 filter TCE:0x2300 rxq desc:0x8000601000004000 MAC:0x763cbdd9d30c

According to the architecture, these buffers need to be 4k aligned buffers,
which is probably the cause of this failure.

-Brian

-- 
Brian King
Linux on Power Virtualization
IBM Linux Technology Center


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html