netdev - Re: [RFC patch (against wireless-next)] include/net/cfg80211.h: wiphy_<level> messages use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1282760736.3667.9.camel@jlt3.sipsolutions.net>
Date:	Wed, 25 Aug 2010 20:25:36 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	"John W. Linville" <linville@...driver.com>
Cc:	Joe Perches <joe@...ches.com>, linux-wireless@...r.kernel.org,
	netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC patch (against wireless-next)] include/net/cfg80211.h:
 wiphy_<level> messages use dev_printk

On Wed, 2010-08-25 at 14:01 -0400, John W. Linville wrote:

> > "<level>dev_driver_string(&wiphy->dev) dev_name(&wiphy->dev): wiphy_name(wiphy): " fmt, ##args
> > 
> > for instance:
> > 
> > [   41.261941] ieee80211 phy0: phy0: Selected rate control algorithm 'minstrel_ht'
> > 
> > ie: redundant.
> > wiphy_name(wiphy) is an inline for dev_name(&wiphy->dev)
> > 
> > So it's appropriate to use:
> > 
> > #define wiphy_<level>(wiphy, fmt, arg...) dev_<level>(&wiphy->dev, fmt, ##arg) 
> > 
> > and the output becomes:
> > 
> > [   41.261941] ieee80211 phy0: Selected rate control algorithm 'minstrel_ht'
> > 
> > Signed-off-by: Joe Perches <joe@...ches.com>
> 
> Everyone OK w/ this version?

I don't care much :)

johannes


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html