netdev - Re: [PATCH net-next-2.6] gro: __napi_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1282769673.2681.170.camel@edumazet-laptop>
Date:	Wed, 25 Aug 2010 22:54:33 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH net-next-2.6] gro: __napi_gro_receive() optimizations

Le mercredi 25 août 2010 à 13:45 -0700, Stephen Hemminger a écrit :
> On Wed, 25 Aug 2010 22:33:51 +0200
> Eric Dumazet <eric.dumazet@...il.com> wrote:
> 
> > compare_ether_header() can have a special implementation on 64 bit
> > arches if CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS is defined
> > 
> > __napi_gro_receive() can avoid a conditional branch to perform device
> > match.
> > 
> > __napi_gro_receive() can be used from vlan_gro_common() instead of being
> > duplicated.
> > 
> > Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> Please, 2 patches. not mixing unrelated bits in one patch.


Well, all this stuff was added in a single commit, 

commit aa4b9f533ed5a22952e038b9fac2447ccc682124
Author: Herbert Xu <herbert@...dor.apana.org.au>
Date:   Sun Feb 8 18:00:37 2009 +0000

    gro: Optimise Ethernet header comparison


But yes, I guess I can cook three different patches, if you feel its
better this way...



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html