netdev - Re: [PATCH] tcp: fix three tcp sysctls tuning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100825.230240.104045673.davem@davemloft.net>
Date:	Wed, 25 Aug 2010 23:02:40 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	anton@...ba.org, netdev@...r.kernel.org, miltonm@....com
Subject: Re: [PATCH] tcp: fix three tcp sysctls tuning

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 26 Aug 2010 07:15:53 +0200

> As discovered by Anton Blanchard, current code to autotune 
> tcp_death_row.sysctl_max_tw_buckets, sysctl_tcp_max_orphans and
> sysctl_max_syn_backlog makes litle sense.
> 
> The bigger a page is, the less tcp_max_orphans is : 4096 on a 512GB
> machine in Anton's case.
> 
> (tcp_hashinfo.bhash_size * sizeof(struct inet_bind_hashbucket))
> is much bigger if spinlock debugging is on. Its wrong to select bigger
> limits in this case (where kernel structures are also bigger)
> 
> bhash_size max is 65536, and we get this value even for small machines. 
> 
> A better ground is to use size of ehash table, this also makes code
> shorter and more obvious.
> 
> Based on a patch from Anton, and another from David.
> 
> Reported-and-tested-by: Anton Blanchard <anton@...ba.org>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

I had something in my tree already, but since I didn't push it out
it's just as easy for me to use this patch instead :-)

Thanks everyone!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html