| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <201008261555.35250.arnd@arndb.de> Date: Thu, 26 Aug 2010 15:55:35 +0200 From: Arnd Bergmann <arnd@...db.de> To: Ben Greear <greearb@...delatech.com> Cc: netdev@...r.kernel.org Subject: Re: [net-next 2/2] macvlan: Enable qdisc backoff logic. On Wednesday 25 August 2010, Ben Greear wrote: > On 08/25/2010 12:59 PM, Arnd Bergmann wrote: > > On Wednesday 25 August 2010 21:27:43 Ben Greear wrote: > >>> I suppose we need to do something in macvtap to handle this as > >>> well, right? A guest trying to send a frame through qemu > >>> or vhost net into macvtap needs to be prevented from sending > >>> more when we get into this path. Right now, we just ignore > >>> the return value of macvlan_start_xmit. > >> > >> I have a similar, though slightly more complex, patch for 802.1q > >> vlans, but I haven't looked at macvtap at all. > >> > >> If these two patches are accepted, I'll post the .1q patch as well. > > > > I think one of us needs to fix macvtap in order for your patch to > > go in, because otherwise there is a memory leak or worse when > > macvtap fails to retransmit the frame. > > With no change, the try_ logic will not be called, so it should > be fully backwards compatible. How? The macvlan driver is used as the back-end for macvtap, so it calls all the same functions: macvtap_write -> macvtap_get_user -> macvlan_start_xmit -> macvlan->queue_xmit -> try_dev_queue_xmit Arnd -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists