netdev - Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100826092929.72b61549@nehalam>
Date:	Thu, 26 Aug 2010 09:29:29 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Masayuki Ohtake <masa-korg@....okisemi.com>,
	LKML <linux-kernel@...r.kernel.org>,
	ML netdev <netdev@...r.kernel.org>,
	Greg Rose <gregory.v.rose@...el.com>,
	Maxime Bizon <mbizon@...ebox.fr>,
	Kristoffer Glembo <kristoffer@...sler.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	John Linn <john.linn@...inx.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	"David S. Miller" <davem@...emloft.net>,
	MeeGo <meego-dev@...go.com>, "Wang, Qi" <qi.wang@...el.com>,
	"Wang, Yong Y" <yong.y.wang@...el.com>,
	Andrew <andrew.chih.howe.khor@...el.com>,
	Intel OTC <joel.clark@...el.com>,
	"Foster, Margie" <margie.foster@...el.com>,
	Toshiharu Okada <okada533@....okisemi.com>,
	Tomoya Morinaga <morinaga526@....okisemi.com>,
	Takahiro Shimizu <shimizu394@....okisemi.com>
Subject: Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH

On Thu, 26 Aug 2010 09:16:12 -0700
Joe Perches <joe@...ches.com> wrote:

> On Thu, 2010-08-26 at 09:05 -0700, Stephen Hemminger wrote:
> > +	for (i = 0; i < 6; i++)
> > +		printk(KERN_INFO "%2.2x%c",
> > +			netdev->dev_addr[i], i == 5 ? '\n' : ':');
> > 
> > you just want:
> >          printk(KERN_INFO "%pM", netdev->dev_addr);
> > 
> > or better yet, convert to dev_printk
> 
> or perhaps better still convert to netdev_info
> 
> My message logging order preference:
> 
> if there's a netif_msg_<type> and a struct net_device
> 	netif_<level>		(struct private *, netif_msg_<type>,
> 				 struct net_device *, fmt, args...)
> if there's a struct net_device
> 	netdev_<level>		(struct net_device *, fmt, args...)
> if there's a struct device
> 	dev_<level>		(struct device *, fmt, args...)
> otherwise
> 	pr_<level>		(fmt, args...)
> 
> 

At this point in process, netdevice isn't registered so it
doesn't have a ethX name. so dev_info would be best.

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html