netdev - Re: [PATCH] bnx2x: fix wrong return from bnx2x_trylock_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Aug 2010 22:04:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eilong@...adcom.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org, vladz@...adcom.com
Subject: Re: [PATCH] bnx2x: fix wrong return from bnx2x_trylock_hw_lock

From: "Eilon Greenstein" <eilong@...adcom.com>
Date: Fri, 27 Aug 2010 07:54:44 +0300

> On Thu, 2010-08-26 at 20:49 -0700, Eric Dumazet wrote:
>> bnx2x_trylock_hw_lock() returns a bool :
>> 
>> true if succeeded to acquire the lock.
>> false in case of error.
>> 
>> -EINVAL is not an acceptable value, since its promoted to true.
> 
> Indeed - thanks Eric!
> 
>> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Acked-by: Eilon Greenstein <eilong@...adcom.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html