netdev - Re: [PATCH 2/2] sky2: Add unidirectional fiber link support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100827133825.494b8098@nehalam>
Date:	Fri, 27 Aug 2010 13:38:25 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Kyle Moffett <Kyle.D.Moffett@...ing.com>
Cc:	linux-kernel@...r.kernel.org, Kyle Moffett <kyle@...fetthome.net>,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] sky2: Add unidirectional fiber link support

On Fri, 27 Aug 2010 15:42:18 -0400
Kyle Moffett <Kyle.D.Moffett@...ing.com> wrote:

> +	/* 
> +	 * Once interrupts are reenabled, reset the PHY again to make sure
> +	 * that we didn't miss a link-up interrupt.  This is especially
> +	 * likely to occur if we're in fiber-txonly mode, as a link-up
> +	 * interrupt is generated almost immediately after we finish
> +	 * programming the PHY.
> +	 */
> +	sky2_phy_reinit(sky2);

Won't this cause a renegotiation causing up to 2 second delay?

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html