netdev - Re: [RFC PATCH] net: blackhole route should always be recalculated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100828.154839.28807157.davem@davemloft.net>
Date:	Sat, 28 Aug 2010 15:48:39 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nicolas.dichtel@...nd.com
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC PATCH] net: blackhole route should always be recalculated

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Fri, 27 Aug 2010 17:47:40 +0200

> It seems to come from commit d11a4dc18bf41719c9f0d7ed494d295dd2973b92,
> which check validy of routes. With this patch, blackhole routes are
> not recalculated (when route table is not updated).
> But this kind of routes are used when xfrm_lookup() returns -EREMOTE,
> so it seems logical to check the route again for next packets, and
> then get the right route.

Thanks Nicolas.  At first glance I think you're approach is correct,
but I will investigate things more closely to make certain of this.

Blackhole routes never had a check operation, because before the XFRM
stuff they were never expected to revalidate in the future.  But with
XFRM now they can, so we likely need to force revalidation now as your
patch does.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html