netdev - Re: [PATCH] net: reset ip_summed in skb_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTimnZDG7O3SxKPiZavw7dj+_OoR8bAq72U7Copjr@mail.gmail.com>
Date:	Sun, 29 Aug 2010 08:35:01 -0700
From:	Jesse Gross <jesse@...ira.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: reset ip_summed in skb_tunnel_rx()

On Sun, Aug 29, 2010 at 12:48 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> It seems we forget to reset skb->ip_summed to CHECKSUM_NONE in various
> tunnels (gre, ipip, sit, ip6_tunnel), before re-entering stack.
>
> Add ip_summed initialization in skb_tunnel_rx(), and remove it from
> ipmr / ip6mr
>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

This is intentional behavior.  For CHECKSUM_COMPLETE packets we
subtract off the checksum of the encapsulating headers that we remove
so we can still get the benefit of checksum hardware for the inner
packet as well.  GRE does this using skb_postpull_rcsum(), for IPIP it
is implicit because the outer IP header was already removed, etc.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html