netdev - Re: [RFC] gro: Is it ok to share a single napi from several devs ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1283107162.2297.32.camel@edumazet-laptop>
Date:	Sun, 29 Aug 2010 20:39:22 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	jarkao2@...il.com, shemminger@...tta.com,
	herbert@...dor.apana.org.au, netdev@...r.kernel.org
Subject: Re: [RFC] gro: Is it ok to share a single napi from several devs ?

Le dimanche 29 août 2010 à 10:06 -0700, David Miller a écrit :
> From: Jarek Poplawski <jarkao2@...il.com>
> Date: Sun, 29 Aug 2010 11:59:51 +0200
> 
> > Actually, when GRO compares napi->dev to skb->dev?
> 
> Hmmm, I thought the code made a skb->dev comparison with the
> existing SKBs in the list when checking for same-flow matches.
> 
> It doesn't, probably based upon the assumption that a NAPI
> instance maps to a unique device, the very topic we're
> discussing right now :-/
> 
> 

It does the check, Stephen added it in the commit I mentioned to start
this thread.

With net-next-2.6 this now reads :


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html