netdev - rp_filter backward compatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C7BCD62.3030805@6wind.com>
Date:	Mon, 30 Aug 2010 17:25:22 +0200
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	netdev <netdev@...r.kernel.org>
CC:	David Miller <davem@...emloft.net>,
	Stephen Hemminger <shemminger@...tta.com>
Subject: rp_filter backward compatibility

I'm surprised by the commit 27fed4175acf81ddd91d9a4ee2fd298981f60295 (ip: fix 
logic of reverse path filter sysctl). This commit breaks backward compatibility.
I know that logic was wrong, but for years it was mandatory to set both 
all.rp_filter and <device>.rp_filter to enable it, ie setting only all.rp_filter 
had no consequences. Now, when all.rp_filter is enabled, RPF is enabled for all 
interfaces.
Help of Kconfig explains:

                                                                 "To turn
           rp_filter on use:

           echo 1 > /proc/sys/net/ipv4/conf/<device>/rp_filter
            *and*
           echo 1 > /proc/sys/net/ipv4/conf/all/rp_filter"

At least, one of this action should be done:
  - fixing help (Documentation/networking/ip-sysctl.txt is up to date)
  - reverting the patch (this will force to set all.rp_filter to 3 if some 
interfaces use loose mode and some others strict mode)

What is your opinion?

Regards,
Nicolas
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html