netdev - Re: [PATCH NEXT 02/10] qlcnic: add api version in reg dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1283268405.2244.4.camel@achroite.uk.solarflarecom.com>
Date:	Tue, 31 Aug 2010 16:26:45 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Amit Kumar Salecha <amit.salecha@...gic.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	ameen.rahman@...gic.com,
	Rajesh Borundia <rajesh.borundia@...gic.com>
Subject: Re: [PATCH NEXT 02/10] qlcnic: add api version in reg dump

On Tue, 2010-08-31 at 07:29 -0700, Amit Kumar Salecha wrote:
[...]
> @@ -345,7 +346,10 @@ qlcnic_get_regs(struct net_device *dev, struct ethtool_regs *regs, void *p)
>  	regs->version = (1 << 24) | (adapter->ahw.revision_id << 16) |
>  	    (adapter->pdev)->device;
>  
> -	for (i = 0; diag_registers[i] != -1; i++)
> +	regs_buff[0] = (0xcafe0000 | (QLCNIC_DEV_INFO_SIZE & 0xffff));
> +	regs_buff[1] = QLCNIC_MGMT_API_VERSION;
> +
> +	for (i = 2; diag_registers[i] != -1; i++)
>  		regs_buff[i] = QLCRD32(adapter, diag_registers[i]);
>  
>  	if (!test_bit(__QLCNIC_DEV_UP, &adapter->state))

You should either bump the version number or put this extra information
at the end of the register dump, not the beginning.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html