netdev - Re: [PATCH net-next-2.6] net: add a comment on netdev->last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100831.133727.235702469.davem@davemloft.net>
Date:	Tue, 31 Aug 2010 13:37:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, joe@...ches.com
Subject: Re: [PATCH net-next-2.6] net: add a comment on netdev->last_rx

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 31 Aug 2010 19:40:16 +0200

> As some driver authors seem to reintroduce dev->last_rx use,
> add a comment to strongly discourage this.
> 
> Since commit 6cf3f41e6c0 (bonding, net: Move last_rx update into bonding
> recv logic), network drivers dont need to update last_rx themselves,
> unless they use this field to implement a timeout.
> 
> Not updating last_rx helps not dirtying a cache line, improving
> performance in SMP.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html