netdev - Re: [RFC] bonding: fix workqueue re-arming races

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100901193859.GB3151@del.dom.local>
Date:	Wed, 1 Sep 2010 21:38:59 +0200
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Jiri Bohac <jbohac@...e.cz>
Cc:	Jay Vosburgh <fubar@...ibm.com>,
	bonding-devel@...ts.sourceforge.net, markine@...gle.com,
	chavey@...gle.com, netdev@...r.kernel.org
Subject: Re: [RFC] bonding: fix workqueue re-arming races

On Wed, Sep 01, 2010 at 09:20:26PM +0200, Jarek Poplawski wrote:
> On Wed, Sep 01, 2010 at 09:11:06PM +0200, Jiri Bohac wrote:
> > On Wed, Sep 01, 2010 at 09:00:37PM +0200, Jarek Poplawski wrote:
...
> > > Hmm#2... Alas, after getting back my sobriety, I've to say that Jay
> > > was wrong: the same workqueue shouldn't matter here. Similar things
> > > are done by other network code with the kernel-global workqueue, eg.
> > > in tg3_close(), rhine_close() etc. 
> > 
> > But these don't do rtnl_lock() inside the work item, do they?
> 
> Exactly. Just like work items cancelled from bond_work_cancel_all()
> after your patch.

IOW: cancel_delayed_work_sync() cares only about the locking of the
cancelled work item - not others, even in the same workqueue. Btw,
testing it with CONFIG_PROVE_LOCKING should give the last answer...

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html