[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20100901.142947.128610236.davem@davemloft.net>
Date: Wed, 01 Sep 2010 14:29:47 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: jeffm@...e.com
Cc: eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net sched: fix kernel leak in act_police
From: Jeff Mahoney <jeffm@...e.com>
Date: Tue, 31 Aug 2010 19:21:42 -0400
> While reviewing commit 1c40be12f7d8ca1d387510d39787b12e512a7ce8, I
> audited other users of tc_action_ops->dump for information leaks.
>
> That commit covered almost all of them but act_police still had a leak.
>
> opt.limit and opt.capab aren't zeroed out before the structure is
> passed out.
>
> This patch uses the C99 initializers to zero everything unused out.
>
> Signed-off-by: Jeff Mahoney <jeffm@...e.com>
> Acked-by: Jeff Mahoney <jeffm@...e.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists