netdev - Re: [PATCH] sky2: don't do GRO on second port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100901145554.4f5abd80@nehalam>
Date:	Wed, 1 Sep 2010 14:55:54 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	jarkao2@...il.com
Cc:	David Miller <davem@...emloft.net>, eric.dumazet@...il.com,
	herbert@...dor.apana.org.au, netdev@...r.kernel.org
Subject: Re: [PATCH] sky2: don't do GRO on second port

On Wed, 01 Sep 2010 14:51:51 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> From: Jarek Poplawski <jarkao2@...il.com>
> Date: Mon, 30 Aug 2010 21:09:00 +0200
> 
> > On Mon, Aug 30, 2010 at 10:51:17AM -0700, Stephen Hemminger wrote:
> >> 
> >>  There's something very important I forgot to tell you.
> >>  What?
> >> 
> >>  Don't cross the GRO streams.
> >>  Why?
> >> 
> >>  It would be bad.
> >>  I'm fuzzy on the whole good/bad thing. What do you mean, "bad"?
> >> 
> >>  Try to imagine all the Internet as you know it stopping instantaneously
> >>   and every bit in every packet swapping at the speed of light.
> >>  Total packet reordering.
> >>  Right. That's bad. Okay. All right. Important safety tip. Thanks, Hubert
> > 
> > Looks really bad to me, so... let's forget it! ;-) (At least until
> > next next.)

The patch wasn't that bad, but the movie quote probably confused you.

Alternatively, the driver could keep track of "current GRO device"
and manually complete the GRO if the next packet changes
the current device.  But it didn't seem worth the effort.

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html