netdev - Re: [PATCH] MAINTAINERS: Add ehea driver as Supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1283366921.2484.8.camel@edumazet-laptop>
Date:	Wed, 01 Sep 2010 20:48:41 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	leitao@...ux.vnet.ibm.com
Cc:	netdev@...r.kernel.org, THEMANN@...ibm.com
Subject: Re: [PATCH] MAINTAINERS: Add ehea driver as Supported

Le mercredi 01 septembre 2010 à 15:23 -0300, leitao@...ux.vnet.ibm.com a
écrit :
> This change just add the IBM eHEA 10Gb network drivers as supported.
> 
> Signed-off-by: Breno Leitao <leitao@...ux.vnet.ibm.com>

Hi Breno.

This reminds me something I noticed in this driver.

In receive path, it unconditionally sets skb->ip_summed to
CHECKSUM_UNECESSARY, for _all_ frames, and this seems very suspect.

Shouldnt cqe->inet_checksum_value be checked or something ?

Are frames with bad checksum completely ignored at hardware level ?

Thanks

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html