netdev - Re: [PATCH net-next] wan: make driver strings const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 01 Sep 2010 19:19:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	acme@...stprotocols.net, andrew.hendry@...il.com,
	elendil@...net.nl, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] wan: make driver strings const

From: David Miller <davem@...emloft.net>
Date: Wed, 01 Sep 2010 18:20:14 -0700 (PDT)

> From: Stephen Hemminger <shemminger@...tta.com>
> Date: Wed, 1 Sep 2010 18:15:15 -0700
> 
>> Change several wan drivers to make strings and other initialize
>> only parameters const.
>> 
>> Compile tested only.
>> 
>> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> 
> Applied, thanks.

You may have "compile tested", but you certainly didn't watch out
for new warnings:

drivers/net/wan/cycx_drv.c: In function 'cycx_setup':
drivers/net/wan/cycx_drv.c:141:2: warning: passing argument 1 of 'get_option_index' discards qualifiers from pointer target type
drivers/net/wan/cycx_drv.c:76:12: note: expected 'long int *' but argument is of type 'const long int *'
drivers/net/wan/cycx_drv.c:151:2: warning: passing argument 1 of 'get_option_index' discards qualifiers from pointer target type
drivers/net/wan/cycx_drv.c:76:12: note: expected 'long int *' but argument is of type 'const long int *'

I've reverted your patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html