lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 3 Sep 2010 10:25:08 +0530 From: Ajit Khaparde <ajitk@...verengines.com> To: David Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org Subject: Re: [PATCH net-2.6 2/3] be2net: fix a bug in UE detection logic On 25/08/10 21:15 -0700, David Miller wrote: > From: David Miller <davem@...emloft.net> > Date: Wed, 25 Aug 2010 14:23:11 -0700 (PDT) > > > From: Ajit Khaparde <ajitk@...verengines.com> > > Date: Wed, 25 Aug 2010 15:57:31 +0530 > > > >> The ONLINE registers can return 0xFFFFFFFF on more than one > >> occassion. On systems that care, reading these registers could > >> lead to problems. > >> > >> So the new code decides that the ASIC has encountered and error > >> by reading the UE_STATUS_LOW/HIGH registers. AND them with > >> the mask values and a non-zero result indicates an error. > >> > >> Signed-off-by: Ajit Khaparde <ajitk@...verengines.com> > > > > Applied. > > You didn't even build test what you submitted to me: > > ERROR: "be_dump_ue" [drivers/net/benet/be2net.ko] undefined! > > I'm reverting both patches. Not sure why this happened and how I missed it because I did compile the driver before sending the patches out. Will take care of this in future. Thanks -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists